::first-letter and ::first-line pseudo-elements are now printed in black #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Makes sense to support these pseudo elements too. Currently we still support IE8 and thus have to use |
|
@drublic Done. 😄 |
|
Thank you, @SidRoberts! Any other opinions? |
|
Nope, I'm happy. 😄 |
|
Thanks again for your work. Now finally landed in master. |
jeffreznik
pushed a commit
to jeffreznik/sw-test
that referenced
this pull request
Oct 15, 2017
Pseudo-elements `::first-letter` and `::first-line` now get printed black by default as `::before` and `::after` are. All pseudo-elements: https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-elements Closes h5bp#1715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.