Add white-space: nowrap to improve accessibility with long hidden content #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we set |
|
Yes you are right, slipped my mind. Added now! |
|
Maybe it would be better to revert back to |
|
Agreed. Let’s use |
|
Fixed that :) yes that makes more sense. |
|
@bekapod Can you squash those commits and clean up the commit message (short description on the first line and then detailed changes below?) |
Add white-space: nowrap to visuallyhidden class so screenreaders can interpret line feeds correctly. Add white-space: inherit to the focusable modifier so when focused the content appears as normal.
|
Done :) |
|
@roblarsen GH lets you squash and merge in the interface. Somewhat new feature (been around a few months), not sure if you noticed it. |
|
Thanks all! |
pzi
added a commit
to thefrontiergroup/standards
that referenced
this pull request
Nov 14, 2016
This prevents the accessible off-screen text from being smushed. See: https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe and discussion here: h5bp/html5-boilerplate#1900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe
This also relates to #1874