Fix ::first-letter in print style causing incorrect rendering in Chrome #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome currently has a bug (when printing) that results in ::first-letter being vertically misaligned under certain (seemingly unrelated) conditions. This PR fixes issue by removing the CSS that causes the issue.
coliff
changed the title
|
I wonder what |
|
@ArmorDarks i believe that's there to make sure any instances of text/box shadow are caught. Not tested, but likely that in at least some browsers pseudo elements aren't caught by a general |
|
@ArmorDarks @patrickhlauke Yes, precisely that. the list of pseudo elements is there because the universal selector isn't enough. It started with this commit |
3 tasks
patrickhlauke
added a commit
to twbs/bootstrap
that referenced
this pull request
Jul 11, 2017
Bootstrap itself doesn't use any `::first-letter` or `::first-line` styles. These selectors also cause(d) problems in IE11 (see h5bp/html5-boilerplate#1799) and currently cause a nasty rendering bug in Chrome where the first letter is vertically shifted (see #21771) As h5bp has now removed these as well, no need to keep and comment them out. See h5bp/html5-boilerplate#1961 / h5bp/html5-boilerplate#1962
slavanga
added a commit
to slavanga/baseguide
that referenced
this pull request
Jul 15, 2017
jeffreznik
pushed a commit
to jeffreznik/sw-test
that referenced
this pull request
Oct 15, 2017
…h5bp#1962) Chrome currently has a bug (when printing) that results in ::first-letter being vertically misaligned under certain (seemingly unrelated) conditions. This PR fixes issue by removing the CSS that causes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome currently has a bug (when printing) that results in
::first-letter being vertically misaligned under certain (seemingly
unrelated) conditions. This PR fixes issue by removing the CSS that
causes the issue.
Thanks @patrickhlauke for the heads-up on this. (#1961)
For reference; the Chrome issue is logged at: https://bugs.chromium.org/p/chromium/issues/detail?id=739800
Types of changes
Checklist: