Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading modernizr and bumping version #2121

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Upgrading modernizr and bumping version #2121

merged 2 commits into from
Mar 18, 2019

Conversation

roblarsen
Copy link
Member

bumps the version number
upgrades modernizr to latest

🍧

@coliff coliff mentioned this pull request Mar 17, 2019
Closed
5 tasks
@coliff coliff self-requested a review March 18, 2019 00:37
coliff
coliff reviewed Mar 18, 2019
View reviewed changes
Copy link
Member

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't version number be v7.1.0 ? (not v7.1.1)

@roblarsen
Copy link
Member Author

👀

And this is why I let PRs sit for a day or two

@coliff
Copy link
Member

coliff commented Mar 18, 2019 •
edited
Loading

heh. I'm updating the package.json now and adding the updates to the CHANGELOG.md to this PR

@coliff
update version to v7.1.0
58618a2 
+ minor devdeps update
+ update CHANGELOG.md
coliff
coliff approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@coliff coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@roblarsen roblarsen merged commit f383380 into h5bp:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff coliff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roblarsen @coliff