Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/ship v7.3.0 #2169

Merged
merged 14 commits into from
Nov 19, 2019
Merged

Release/ship v7.3.0 #2169

merged 14 commits into from
Nov 19, 2019

Conversation

roblarsen
Copy link
Member

No description provided.

roblarsen and others added 2 commits October 23, 2019 15:12
@roblarsen
Update CHANGELOG.md
04a90d7
@coliff
Updates for v7.3.0
f1dd1c5 
- Minor devdeps update for glob and mocha
- Update CHANGELOG with additonal changes and formatting fix (remove leading spaces and extraenous linebreak)
- Bump version number in `package.json`
@roblarsen
Copy link
Member Author

👀

@coliff
Copy link
Member

coliff commented Oct 25, 2019 •
edited
Loading

minor thing really, but I realised i had Prettier formatting turned on (sorry!) when editing the CHANGELOG.md and it changed all the bulletpoints from * to - .
what do you think? worth changing it back or fine keeping it like it is in this PR?

@coliff
Copy link
Member

coliff commented Oct 25, 2019

In any case, I suggest to change the bullet:

to:

@roblarsen
Copy link
Member Author

roblarsen commented Oct 25, 2019 •
edited
Loading

I read it backwards. I'll update the file.

@roblarsen
Copy link
Member Author

small updates

@coliff
Copy link
Member

coliff commented Oct 26, 2019

I just saw that Modernizr v3.8.0 was released. Worth updating?

https://github.com/Modernizr/Modernizr/blob/v3.8.0/CHANGELOG.md

@roblarsen
added modernizr 3.8
2b2bb45 
also updated with bet a flag to test github actions
@coliff
Copy link
Member

coliff commented Oct 27, 2019

nice one on updating Modernizr 👍 .

On the CHANGELOG.md, did you search and replace - with *? There are some places where - make more sense. see the commit diff to see what I mean.
https://github.com/h5bp/html5-boilerplate/pull/2169/files

@roblarsen roblarsen mentioned this pull request Nov 6, 2019
Closed
coliff
coliff reviewed Nov 6, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
coliff
coliff reviewed Nov 6, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@roblarsen roblarsen requested a review from coliff November 7, 2019 15:28
@roblarsen
Copy link
Member Author

@coliff I would like today to be the day, so if you have time for another once over.

@coliff
Copy link
Member

coliff commented Nov 7, 2019

cool - checking now...

  • For this final PR should the version number in package.json be 7.3.0 (and not 7.3.0-rc1)
  • Not critical at all, but the line lengths in the markdown files vary a lot. We should properly sort this out at some point (not certain of the best way right now though)

@roblarsen
Copy link
Member Author

For this final PR should the version number in package.json be 7.3.0 (and not 7.3.0-rc1)

I actually made the change and never pushed it. pushing now.

@coliff
Copy link
Member

coliff commented Nov 7, 2019 •
edited
Loading

just spotted something else... the html.md includes part of the HTML template with:
<script src="js/vendor/modernizr-3.7.1.min.js"></script>
this should now be:
<script src="js/vendor/modernizr-3.8.0.min.js"></script>

@coliff
Copy link
Member

coliff commented Nov 7, 2019 •
edited
Loading

ugh, I'm finding more things... on extend.md we should change that Google+ / Schema.org section as it needs updating (as Google+ is dead). At the very least we should:

  • Change that section title to just: Schema.org
  • Remove 'While it helps you to control information displayed on Google+, '
  • In that example HTML snippet change http://schema.org/Article to https://schema.org/Article (REF: https://schema.org/docs/faq.html#19 )

@roblarsen
Copy link
Member Author

good eye. I can make the changes after lunch.

@coliff
Copy link
Member

coliff commented Nov 7, 2019

a few last (optional) things I thought of:

  • Could consider bumping min version of NPM in package.json to v10. v8 is in maintenance mode and will be unsupported in 2 months time. (https://nodejs.org/en/about/releases/)
  • There's a few packages in package.json which could be bumped babel, eslint, eslint-plugin-mocha, glob and ssri.
  • In the .editorconfig we have a rule to NOT trim trailing spaces in markdown. I don't know why that is set there - trailing whitespaces are annoying and I don't think ever needed. I'm not 100% certain on this though...

@roblarsen
Copy link
Member Author

Back from vacation.

@coliff
Copy link
Member

coliff commented Nov 19, 2019

welcome back :-) I'm around all day if I can help out with anything

@coliff
Copy link
Member

coliff commented Nov 19, 2019 •
edited
Loading

lookin' good. Just need to update the date in the CHANGELOG.md for the new release I think.

@roblarsen roblarsen merged commit e1c4afe into master Nov 19, 2019
@roblarsen
Copy link
Member Author

the npm publish github action worked as advertised: https://www.npmjs.com/package/html5-boilerplate

@roblarsen roblarsen deleted the release/ship-v7.3.0 branch April 17, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliff coliff Awaiting requested review from coliff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roblarsen @coliff