HCCore first pull request #176
Conversation
Changed the command to make you active command to be /notafk instead of /afk
not done
NEW advancement: Master mob Slayer Achieved by killing Each hostile mob 10 times
Nerw advancement mine 10 pieces of obsidian by hand
no sleep gotten by not sleeping for a full week
|
Hi, thanks for the pr
|
|
YAY!!!!!! |
src/main/java/com/hackclub/hccore/playerMessages/afk/RunAFKMessage.java
Outdated
Show resolved
Hide resolved
updated to refer to the fixes that were made by 456dev
| .announceChat() | ||
| .showToast() | ||
| .description("Kill EVERY hostile Mob 10 times"); | ||
| static final int maxProgression = 640; // 10 times for each of the 64 hostile mobs |
There was a problem hiding this comment.
Wouldn't this mean that I could just kill 640 endermen in a farm and get the advancement?
There was a problem hiding this comment.
i dont know
i thought it meant that you need to kill 10 of each hostile mob to get the advancement
There was a problem hiding this comment.
Hmm I haven't tested it, but from what I see, it's not tracking how many of each mob you've killed, just how many mobs in total
There was a problem hiding this comment.
@polypixeldev i dont know how to make it count 10 of each mob death tho...
There was a problem hiding this comment.
Yeah, this is a bit of a tough one to do. The only way I can think of would be to add a map to the PlayerData class which stores how many of each mob they've killed, and update it accordingly in the EntityDeathEvent handler.
There was a problem hiding this comment.
you don't really need a map as player stats are already stored
I wanted to get into java mod/plugin making and so i decided to start simple by creating some new advancements
i mostly copied the code from other advancements and used bing when needed for help
i hope they are cool lol