Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header should still be clickable while the loading modal is active #1783

Closed
4 tasks done
ryanfchase opened this issue Jun 26, 2024 · 5 comments · Fixed by #1794
Closed
4 tasks done

Header should still be clickable while the loading modal is active #1783

ryanfchase opened this issue Jun 26, 2024 · 5 comments · Fixed by #1794
Assignees
Labels
P-feature: Map P-feature: Navigation Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours
Milestone

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Jun 26, 2024

Overview

We need to make the Header clickable when the loading modal is active so that users can access other tabs while data is loading.

Action Items

  • Contain the loading modal to the Map component
    • the loading modal's container should not extend into the Header or Footer
    • the Header and Footer should not be dimmed while the loading modal is rendered
  • Ensure that we can click a navlink while the loading modal is present
  • Returning from a different page (via navlink) does not interrupt the data loading process
    • if the data is still loading, continue to show the loading modal
    • if the data is loaded, show the acknowledgement modal
  • fill in screenshot of implemented changes in Resources/Instructions below

Resources/Instructions

Screenshot of Desired Area to Change

Loading Modal Disables Header/Footer
image

Acknowledge Modal Disables Header/Footer
image

Screenshot of implemented changes

Loading Modal Visible Header/Footer
onload

Acknowledge Modal Visible Header/Footer
modal

@ryanfchase ryanfchase added Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours P-feature: Map P-feature: Navigation ready for dev lead ready for developer lead to review the issue Pre-Launch Describes an issue that must be completed in order to launch labels Jun 26, 2024
@ryanfchase ryanfchase added this to the 04 - Map Page milestone Jun 26, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Jun 26, 2024
@bberhane
Copy link
Member

@Skydodle PM has signed off, so OK to move to prio backlog upon your approval.

@Skydodle
Copy link
Member

Looks good to me. This ticket is ready to be picked up.

@Skydodle Skydodle added ready for prioritization and removed ready for dev lead ready for developer lead to review the issue labels Jun 27, 2024
@Skydodle Skydodle moved this from New Issue Approval to Prioritized Backlog (ready to be assigned) in P: 311: Project Board Jun 27, 2024
@traycn traycn self-assigned this Aug 15, 2024
@ryanfchase
Copy link
Member Author

Hi @traycn,

Please leave a comment with the following items:

  • ETA
  • Any blockers this week?
  • availability for communications during the week

@traycn
Copy link
Member

traycn commented Aug 15, 2024

Hi @ryanfchase

ETA: Friday 8/16
Blockers: None
Availability: Tues-Fri after 5pm

@traycn
Copy link
Member

traycn commented Aug 19, 2024

Updated ETA: Tuesday 8/20
Blockers: None
Availability: Tues - Fri after 5pm

@github-project-automation github-project-automation bot moved this from In Review to Done (without merge) in P: 311: Project Board Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Map P-feature: Navigation Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

4 participants