1783 header active while modal active #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @traycn, I was able to checkout the branch and it all looks good and working like the above screenshot for me! |
funbunch
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1783
Info
Display the Header (navbar) while a modal is active.
Update: Added Footer visibility using the same zIndex value.
Changes Made
Updated the Header component with a z-index value that is higher than the modal z-index.
position: 'relative'andzIndex: 1400to Header (AppBar MUI).-- Value is defined based on MUI component zIndex hierarchy.
Screenshot of UI change:
Loading Modal Visible Header/Footer
Acknowledge Modal Visible Header/Footer
Resources:
https://mui.com/material-ui/customization/z-index/
Pre-merge Checklist
mainbranch