Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check email should be lowercase #1457

Closed
wants to merge 15 commits into from

Conversation

evanyang1
Copy link
Member

@evanyang1 evanyang1 commented Aug 4, 2023

Fixes #1464

Frontend check to make sure new user email is lowercase.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied
Visuals after changes are applied

image

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b evanyang1-db-1456 development
git pull https://github.com/evanyang1/VRMS.git db-1456

@trillium
Copy link
Member

trillium commented Aug 7, 2023

My appologies Evan, I didn't get back to this soon enough to give you more direction here. We're not looking for a validation error statement, we're looking for the information sent to the backend to be transformed to lowercase on the api request:

// client/Auth.js 
if (isEmailValid) {
      const userData = await checkUser(email, LOG_IN);
// transform to:
      const userData = await checkUser(email.toLowerCase(), LOG_IN);

      if (userData) {
...

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked over slack, but requesting changes to make transform the email auth api call to be toLowerCase()

Brad and others added 14 commits August 9, 2023 16:42
Force helperText to have content to prevent layout shift on  validation errors
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
1. remove the previous commit's contents
2. convert to lowercase email in Auth.js
@trillium
Copy link
Member

trillium commented Aug 11, 2023

@evanyang1 Can you please rebase this commit and push it back up again with only the necessary changes

# Rebase to current development
git fetch upstream
git rebase upstream/development


# rebase to edit whichn commits are used:
git rebase -i HEAD~2

# rebase contents should be:
# pick 9193340 feat: check email should be lowercase
# pick c58b97e !fix: 1. remove the previous commit's contents 2. convert to lowercase email in Auth.js

# change to
drop 9193340 feat: check email should be lowercase # drop this commit, old unused code
reword c58b97e !fix: 1. remove the previous commit's contents 2. convert to lowercase email in Auth.js 

# reword commmit c58b97e
feat: Add .toLowerCase for auth case senisitivity

@evanyang1 evanyang1 closed this Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add .toLowerCase to front end auth db query
2 participants