-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate Google drive, but not sure how to use custom error msg #1526
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
FYI - the requirement to validate Google Drive has changed since this PR was delivered, and this function will likely be dropped. I will confirm with the stakeholder tomorrow and update/close this PR pending approval. |
@JackHaeg Looking to resolve this, did we get confirmation on this requirement? |
@trillium & @evanyang1 Per discussion with stakeholder, Google Drive URL is a required field. So, this PR is still relevant and this fix is necessary. However, we ask that prior to merging, please update the custom error message to read "Invalid URL". Once this custom error message is in place, please feel free to merge this PR if it meets all other acceptance criteria. Plan to discuss during today's All Team MTG call. |
@trillium Can you please provide Evan with some assistance on how to create this custom error message ("Invalid URL")? |
Plan for this PR:
|
This is a good start and could potentially be used by the next person who picks up #1369 |
Fixes #1369
(Sort of)
What changes did you make and why did you make them ?
validate
function to data.js for google drive field!! I didn't find out how to do a custom error message.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied