Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts.1411 #1539

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Ts.1411 #1539

merged 2 commits into from
Nov 7, 2023

Conversation

trillium
Copy link
Member

@trillium trillium commented Nov 5, 2023

Fixes #1411

What changes did you make and why did you make them ?

  • Shift code from if/then block to helper function
  • Switch event.date to event.startTime

The bug we were experiencing was because events were being based off of the event.date property rather than the event.startTime property. When the createAndFilterEvents worker ran, it was using old data that the user wasn't setting within the app.

There are already helper functions made on the front end to transfer a timestamp from 6:00 PM to a valid Date object. The recurring events model has these saved in theory at the right spots, but it is also recommended that project managers update their start times of their events within the app.

If they wish to keep their start times, please update them twice eg 7:00 PM to 6:00 PM and back to 7:00 PM. This way we can ensure that the correct startTime is saved in the db.

Copy link

github-actions bot commented Nov 5, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Spiteless-ts.1411 development
git pull https://github.com/Spiteless/VRMS.git ts.1411

Copy link
Member

@bkmorgan3 bkmorgan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo -- per Trillium

@trillium trillium merged commit d6d81a1 into hackforla:development Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Users Cannot Check In
2 participants