-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create redesigned "Users" page #1798
base: development
Are you sure you want to change the base?
Create redesigned "Users" page #1798
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! MUI is being used for the buttons, the styling looks correct and the links work as expected (user permission search page to be added).
I noticed that the package.json
, package-lock.json
and yarn.lock
files show updates, I don't know enough about back-end to say whether this would be an issue to merge or not, so I will leave this to the lead devs.
Edit: I'd love to hear from a lead dev on the above comment so I can know how to approach moving forward.
@pluto-bell, thanks for taking a look at the PR. I think you're right that the package.json, package-lock.json and yarn.lock files shouldn't be included in the PR. @trillium, is this okay? I tried to remove those files from the PR, but it's still showing this in the files changed. If not, what is the proper command to remove the files from PR? |
Per @trillium: restore the files using:
@trillium will plan to meet with @vorleakyek this week to restore the json files. |
fe36cf4
to
79c59f0
Compare
…d users-permission-search
79c59f0
to
ef5c3a0
Compare
ef5c3a0
to
29f1c9b
Compare
Thanks @trillium for helping me restore the JSON files yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, everything looks good to me and is working as expected (:
Fixes #1751
What changes did you make and why did you make them ?
/users/
with links to/users/user-search
and/users/permission-search
as separate buttons.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied