Add footer #121
Add footer #121
Conversation
There was a problem hiding this comment.
Looking like a great addition! I have several notes, but I think the two blocking ones are the color of the links on hover and the missing margin/padding between the content and the footer. They're not particularly breaking, so I can improve if we want to leave those for the future.
| 'href', | ||
| 'https://github.com/codeforamerica/brigade-project-index-statusboard/issues/new?assignees=&labels=&template=feature_request.md&title=' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Do you also want to make sure the link to the repository is there?
There was a problem hiding this comment.
I think I am skipping it, I am not sure that I want the GitHub repository link at all :/
I am not sure if it adds anything, or if it is better to have it focused on requesting bug and issue reports
| width: 100%; | ||
| min-height: 5rem; | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; |
There was a problem hiding this comment.
These don't seem to have an effect. Maybe worth thinking about removing them.
There was a problem hiding this comment.
Also, I tend to prefer that the space an element takes up be determined by padding, etc. Using height can be hard to debug for a new person later.
|
|
||
| p { | ||
| color: var(--cfa-white); | ||
| font-family: var(--font-family-text); |
There was a problem hiding this comment.
This doesn't seem necessary and it should probably inherit from the rest of the document, so maybe worth removing.
| color: var(--cfa-white); | ||
| font-family: var(--font-family-text); | ||
| margin-left: 1.0rem; | ||
| margin-right: 1.0rem; |
There was a problem hiding this comment.
The links in here have a hover color that blends into the background. Changing that could be a more accessibility friendly improvement.
Alternatives
Research how to collect feedback in an easy and reusable fashion.
Research Google form.
Current
Adds a footer highlighting that feature requests and bug reports can be made in the GitHub repository.