Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG Routing Testing #1249

Closed
13 of 17 tasks
Tracked by #1241
, #1267
...
sydneywalcoff opened this issue Mar 11, 2024 · 16 comments · Fixed by #1585 or #1613
Closed
13 of 17 tasks
Tracked by #1241
, #1267
...

LG Routing Testing #1249

sydneywalcoff opened this issue Mar 11, 2024 · 16 comments · Fixed by #1585 or #1613
Assignees
@whitneywind
Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 3pt Can be done in 13-18 hours Status: Update Requested
Milestone
00. Stakeholder R...

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented Mar 11, 2024 •
edited by whitneywind
Loading

Dependency

Overview

Testing is an important part of the development process that has been ignored in the Expunge Assist process thus far. To create a better protected codebase, we want to retroactively implement tests.

Create tests for the below scenarios. Feel free to include additional tests if you find opportunities for more coverage to test our routing in the letter generator.

Action Items

  • Static pre-form pages route correctly
    • Start Now -> Welcome
    • Welcome -> Before you Begin
    • BYB -> advice
    • advice - > Form
  • Static form pages route correctly
    • Introduction -> Intro Preview
    • Intro preview -> Involvement
    • Future Goals -> FG preview
    • FG preview -> Why
    • Why -> Why preview
    • Why preview -> Finalize
    • finalize -> finalize preview
  • Dynamic form pages route correctly
    • form uses formState to determine route
    • pages are ordered: employment, unemployment, self-improvement, education, parenting, community service, something else

Resources/Notes

Jest
React Testing Library
@sydneywalcoff sydneywalcoff mentioned this issue Mar 11, 2024
Open
16 tasks
@sydneywalcoff sydneywalcoff added role: development anything related to code feature: technical standards accessibility, usability, unit testing, etc. labels Mar 15, 2024
@sydneywalcoff sydneywalcoff added this to the Launch Prep 2.0 milestone Mar 15, 2024
@sydneywalcoff sydneywalcoff added priority: low size: 3pt Can be done in 13-18 hours front-end type of development task relating to the website DevOps type of development task related to Process, Github Actions, and Deployment draft Not yet ready to be worked on issue level I: request Smallest type of issue; Typically can be completed by one person dependency The issue or reason why this issue is in the icebox labels Mar 20, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Mar 21, 2024
Closed
14 tasks
@sydneywalcoff sydneywalcoff changed the title Routing Testing LG Routing Testing Mar 27, 2024
@sydneywalcoff sydneywalcoff removed the draft Not yet ready to be worked on label Mar 27, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Mar 27, 2024
Closed
@sydneywalcoff sydneywalcoff removed the dependency The issue or reason why this issue is in the icebox label Mar 27, 2024
@sydneywalcoff sydneywalcoff mentioned this issue May 29, 2024
Open
@whitneywind whitneywind self-assigned this May 30, 2024
@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

@whitneywind
Copy link
Member

My initial estimate is 1 week to complete this testing task! Will update ETA if needed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@ExperimentsInHonesty ExperimentsInHonesty moved this to In Progress (active) in P: EA: Project Board Jun 14, 2024
@whitneywind
Copy link
Member

Still working on this! I have written tests that test the static pre-form page routing. Now I'm determing how to test the form routing specifically without having the test also access and fill out the entire form.

@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@whitneywind whitneywind mentioned this issue Jun 26, 2024
Closed
@whitneywind whitneywind moved this from In Progress (active) to Ready for Review in P: EA: Project Board Jun 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

4 similar comments
@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@whitneywind
Copy link
Member

The tests are finished, but I am still working on fixing some bugs that are caused by using certain versions of node. As of now, node versions 16 and 18 work without problems.

@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

4 similar comments
@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@github-actions GitHub Actions
Copy link

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

sydneywalcoff added a commit that referenced this issue Sep 30, 2024
@sydneywalcoff
Merge pull request #1584 from hackforla/new-routing-tests-1249
2fcf8c2 
routing tests on new branch for #1249
@sydneywalcoff sydneywalcoff mentioned this issue Sep 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in P: EA: Project Board Sep 30, 2024
sydneywalcoff added a commit that referenced this issue Sep 30, 2024
@sydneywalcoff
Revert "routing tests on new branch for #1249"
79db173
sydneywalcoff added a commit that referenced this issue Sep 30, 2024
@sydneywalcoff
Merge pull request #1587 from hackforla/revert-1584-new-routing-tests…
aba6437 
…-1249

Revert "routing tests on new branch for #1249"
@eburdekin eburdekin reopened this Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress (active) in P: EA: Project Board Oct 9, 2024
This was referenced Oct 9, 2024
Merged
Merged
@github-project-automation github-project-automation bot moved this from In Progress (active) to Done in P: EA: Project Board Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitneywind whitneywind

Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: technical standards accessibility, usability, unit testing, etc. front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 3pt Can be done in 13-18 hours Status: Update Requested
Projects
P: EA: Project Board
Status: Done
Milestone
00. Stakeholder Review 2.0
Development

Successfully merging a pull request may close this issue.

Dev hackforla/expunge-assist
Dev hackforla/expunge-assist
3 participants
@sydneywalcoff @whitneywind @eburdekin