#996-add last popup #1078
Merged
#996-add last popup #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getting rid of popup on pageload
sydneywalcoff
requested changes
Jan 21, 2024
There was a problem hiding this comment.
Hey @troymathis! The final popup looks great!
Just a couple notes:
- The 'Return Home' button in the popup just closes the popup. Can you update it to clear the form state and reroute to the home page?
- The other popups have the outer padding removed(see screenshots below). Can you make sure your style is only being added on the final popup?
The live site:
your branch
missing the padding between the outside of the popup and the image.
… affirmation popups fixed (styling)
sydneywalcoff
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
@troymathis looks good, Troy! Thanks for making those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
popup component working on finalize preview page;
styling is a little wonky