Before you begin 1077 #1110
Before you begin 1077 #1110
Conversation
There was a problem hiding this comment.
Hey @davidwiese ! This looks great! My only request is that we import and use a material UI icon instead of importing one.
Check out this one.
Check out the Advice.tsx for some insight on how to style and use the icons.
@sydneywalcoff |
There was a problem hiding this comment.
Remove this and we're good! :)
There was a problem hiding this comment.
@sydneywalcoff Woops. All set!
| [breakpoints.down('sm')]: { | ||
| marginTop: 40, | ||
| }, | ||
|
|
||
| [breakpoints.down('xs')]: { | ||
| marginTop: 40, | ||
| }, | ||
| }, | ||
|
|
There was a problem hiding this comment.
@davidwiese jk one last thing. Is this supposed to be here? I'm not seeing a button container on the Before you Begin page, and we don't want unintended consequences on the rest of the buttons?
There was a problem hiding this comment.
@sydneywalcoff
Yea, that's adjusting the margin between the Before You Begin section and the Buttons on the bottom of the page for mobile layouts (part of the <FlowNavigation /> component).
There was a problem hiding this comment.
@sydneywalcoff Ok I was just overthinking the problem, or was just misunderstanding the goal of the design change.
My initial understanding was that the buttons should be a fixed distance from the alert, when really it's just the minimum distance that is desired.
Should be good to go now!
| @@ -48,6 +48,7 @@ const useUtilityStyles = makeStyles<Theme>( | |||
| flexDirection: 'row', | |||
| width: '100%', | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
@davidwiese seems silly, but lets remove this added line so you aren't making changes to this file at all.
There was a problem hiding this comment.
@davidwiese looks good!! I'll merge now
remember to re-add the ready for dev lead label when its ready again after corrections.
Fixes #1077
Changes made
Keep your browser openalert sectionScreenshots of proposed changes
Desktop
Mobile