1172 fix faq alignment #1258
Merged
1172 fix faq alignment #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sydneywalcoff
requested changes
Mar 16, 2024
There was a problem hiding this comment.
Hey @davidwiese! This looks really good. I left one request, but it's pretty small.
| @@ -48,6 +53,7 @@ const useStyles = makeStyles(({ breakpoints, palette, spacing }) => | |||
|
|
|||
| [breakpoints.down(breakpoints.values.md)]: { | |||
| flexDirection: 'column', | |||
| marginLeft: '-8px', | |||
products/statement-generator/src/components-layout/AppFooter.tsx
Outdated
Show resolved
Hide resolved
@sydneywalcoff Made adjustments to get everything lined up at all breakpoints without negative margins |
sydneywalcoff
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
@davidwiese looks great! Thank you for making those changes!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172
Changes made
AppFooterto exactly match and align withAppHeader- otherwise none of the content would be aligned with bothFAQHeadercontent width to stay aligned with theAppHeaderandAppFooterFAQHeadertext and image to have correct line numbers and spacingFAQContainercontent width to stay aligned with theAppHeaderandAppFooterReason for changes