1230 Make Header/Footer Logo Accessible #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eburdekin
changed the title
sydneywalcoff
requested changes
Mar 17, 2024
There was a problem hiding this comment.
@eburdekin Thanks for such a quick turnaround on this!
Not a problem with your code, but the legacy code here is sloppy in how it separates the logo from the text in the header. I'll have to make an issue refactoring this.
In the meantime, can you add an aria-label with the same text to the EA text part of the logo in the header? Currently it just reads the EA text which isn't as clear as what you added to the image part of the logo.
|
@sydneywalcoff thanks for reviewing! All sounds good - happy to take a crack at creating the issue to refactor the code if that'd be helpful. |
sydneywalcoff
approved these changes
Mar 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1230
Changes made
aria-labelto link els (image and text) describing each link as 'Expunge Assist home'Reason for changes
aria-labelsandaltattributes to identify the selected element to the user. Because the Header and Footer Logos link to the Landing page dynamically and the image doesn't have alt text, Screen Readers don't know what to call these links.