Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1235 Code how it works section #1324

Merged
merged 3 commits into from
Apr 15, 2024
Merged

1235 Code how it works section #1324

merged 3 commits into from
Apr 15, 2024

Conversation

hasham-qaiser
Copy link
Member

Fixes: #1235

Changes made:

  • Removed "How it works" SVG on Landing.tsx and created a component to replicate it.

Reason for changes:

  • For improved usability and easier for users who require a screen reader.

@hasham-qaiser hasham-qaiser added the ready for dev lead task ready for dev lead to evaluate label Apr 9, 2024
sydneywalcoff
sydneywalcoff requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hasham-qaiser ! It's looking really good! I noticed a small thing. On mobile, the steps get cut off just a little bit. Check the figma for spacing details
Screenshot 2024-04-09 at 3 44 40 PM

@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Apr 10, 2024
@sydneywalcoff sydneywalcoff mentioned this pull request Apr 10, 2024
Open
@hasham-qaiser hasham-qaiser added the ready for dev lead task ready for dev lead to evaluate label Apr 11, 2024
sydneywalcoff
sydneywalcoff approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasham-qaiser Looks good Hasham thank you!

@sydneywalcoff sydneywalcoff merged commit 1d2065d into dev Apr 15, 2024
1 check passed
@sydneywalcoff sydneywalcoff deleted the 1235-new-branch branch April 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneywalcoff sydneywalcoff sydneywalcoff approved these changes

Assignees
No one assigned
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasham-qaiser @sydneywalcoff