Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button testing 1243 #1354

Merged
merged 4 commits into from
May 15, 2024
Merged

button testing 1243 #1354

merged 4 commits into from
May 15, 2024

Conversation

whitneywind
Copy link
Member

Completes issue #1243

  • I wrote tests that check that the button component correctly loads, passes props, can be disabled/enabled, can be focused, and allows the focus to move past.

@sydneywalcoff sydneywalcoff mentioned this pull request Apr 24, 2024
Open
@sydneywalcoff sydneywalcoff added the ready for dev lead task ready for dev lead to evaluate label Apr 24, 2024
sydneywalcoff
sydneywalcoff requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @whitneywind !

This looks great! I had a few comments and questions, but nothing major. Thank you for your work on this

P.S. remember to add the ready for dev lead label when you're ready to review

products/statement-generator/src/tests/buttons.test.tsx Outdated Show resolved Hide resolved
products/statement-generator/src/tests/buttons.test.tsx Outdated Show resolved Hide resolved
@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Apr 24, 2024
@whitneywind whitneywind added the ready for dev lead task ready for dev lead to evaluate label May 6, 2024
sydneywalcoff
sydneywalcoff requested changes May 10, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitneywind last thing!

products/statement-generator/src/tests/buttons.test.tsx Outdated Show resolved Hide resolved
@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label May 10, 2024
@whitneywind whitneywind added the ready for dev lead task ready for dev lead to evaluate label May 14, 2024
@sydneywalcoff sydneywalcoff self-requested a review May 15, 2024 03:46
sydneywalcoff
sydneywalcoff approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitneywind Looks great! Thank you!

@sydneywalcoff sydneywalcoff merged commit 5f7cbf1 into dev May 15, 2024
1 check passed
@sydneywalcoff sydneywalcoff deleted the button-testing-1243 branch May 15, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneywalcoff sydneywalcoff sydneywalcoff approved these changes

Assignees
No one assigned
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitneywind @sydneywalcoff