-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify contributing #395
Conversation
- compose file no longer uses versioning - Dockerfile env vars use = signs
CONTRIBUTING.md will be a simplified page that links to the mkdocs contributing page.
These can be auto-generated if needed
6520a71
to
0dff0df
Compare
Maybe the 2 vs. 3 column display needs some more thinking through. I'm going to remove that and recreate screenshots for this PR. The reasoning is that the Stripe docs use the 3-column format, and it's been the gold standard for software API documentation for a long time. Maybe it's something that users (client developers) prefer. |
0dff0df
to
4dd7b2e
Compare
These are the developer guides for how to do specific things with the project. | ||
|
||
1. [Add model and API endpoints](add-model-and-api-endpoints.md) | ||
1. [Create initial data migrations](create-initial-data-migrations.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 6: Change to 'Create initial data scripts' - and maybe change the name of the linked .md file too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should change the wording here.
Migrations is the term Django uses for this type of scripts. They don't work alone, but have to be run by Django's migration system. https://docs.djangoproject.com/en/5.1/topics/migrations/
It took a while to compare and figure out the best format to keep the initial data and insert them into the database. I should write up a DR to document why.
docs/contributing/dev_environment.md
Outdated
|
||
1. Browse to the web admin interface at `http://localhost:8000/admin/` and confirm the admin site is running. Use DJANGO_SUPERUSER_USERNAME and DJANGO_SUPERUSER_PASSWORD from .env.docker for credentials. | ||
|
||
See our documentation for [Working with Docker](http://localhost:8005/contributing/tools/docker/#working-with-docker) for more useful Docker commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 165: is the link to Working with Docker page to be inserted later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! localhost is definitely a placeholder link that didn't get cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! A few tiny corrections and a couple of comments, that's all.
7e35a9e
to
7146082
Compare
Fixes #267
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website
Before link
Visuals before changes are applied
After link
Visuals after changes are applied