Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure withToastProvider HOC for testability #973

Closed
4 tasks
fyliu opened this issue Oct 6, 2021 · 3 comments
Closed
4 tasks

Restructure withToastProvider HOC for testability #973

fyliu opened this issue Oct 6, 2021 · 3 comments
Labels
dev productivity Features that help with dev productivity and workflow dev: tests feature: Code Cleanup level: hard pbv: dev All engineering issues priority: SHOULD HAVE refactor Release Note: Shows as System Update role: front-end Front End Developer size: missing

Comments

@fyliu
Copy link
Member

fyliu commented Oct 6, 2021

Dependency

Overview

We need to use the same code that can implement Toasts consistently through out the app.

Detail

  • withToastProvider has been a blocker to testing components that use the Toast context, for example Fix Feedback Page jest tests #670 and similar code that were merged without tests.
  • See if it can be restructured in a way that allows testing components that consume Toast context.

Action Items

Resources/Instructions

@fyliu fyliu added role: front-end Front End Developer level: hard dev: tests refactor Release Note: Shows as System Update priority: SHOULD HAVE feature: Code Cleanup dev productivity Features that help with dev productivity and workflow labels Oct 6, 2021
@KPHowley
Copy link
Member

KPHowley commented Oct 7, 2021

@fyliu - I would love to see @seenaiype and our UI/UX teams thought on toast's in general before adding this to the backlog- They are been working on an new style guide / Audit so I'm going to add #536 and #972 as blockers on this.

@Biuwa
Copy link
Member

Biuwa commented Mar 2, 2023

From John:

'From the comments, it looks like Kevin Howley was hoping that the style guide would include a new wireframe for how toasts look, so made this issue dependent upon the design system effort at the time. Toasts are the little messages that show up and then disappear after a few seconds that you see on some of the screens. I agree that they look sort of crude, and, if I recall correctly, the different toast appear in various different locations on the screen - so they probably could look better.
Issue #973 is just about changing the way the code for toasts is written to reduce duplication of code and make the code to implement each different toast simpler - it sort of falls under the heading of "code cleanup"'

@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency Issues that cannot be worked on until another issue is closed label Mar 25, 2023
@ExperimentsInHonesty ExperimentsInHonesty moved this to Prioritized Backlog in P: TDM: project board Jun 11, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the pbv: dev All engineering issues label Jun 11, 2024
@entrotech
Copy link
Member

Changed implementation of Toasts to use a React Context, instead of a HOC

@entrotech entrotech closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Prioritized Backlog to On Dev - not yet pushed to Prod in P: TDM: project board Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev productivity Features that help with dev productivity and workflow dev: tests feature: Code Cleanup level: hard pbv: dev All engineering issues priority: SHOULD HAVE refactor Release Note: Shows as System Update role: front-end Front End Developer size: missing
Projects
Status: Released
Development

No branches or pull requests

7 participants