FE: fixed forward-engineering of default and symboldDefault values of enum #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras-dubyk
reviewed
Mar 25, 2024
Comment on lines
209
to
212
| const redundantAttributes = _.reject( | ||
| GENERAL_ATTRIBUTES, | ||
| attribute => attribute === 'default' && typeSchema.type === 'enum', | ||
| ); |
There was a problem hiding this comment.
Will it be more readable this way?
Suggested change
| const redundantAttributes = _.reject( | |
| GENERAL_ATTRIBUTES, | |
| attribute => attribute === 'default' && typeSchema.type === 'enum', | |
| ); | |
| const redundantAttributes = typeSchema.type === 'enum' ? _.without(GENERAL_ATTRIBUTES, 'default') : GENERAL_ATTRIBUTES; |
Ignore it if you disagree.
taras-dubyk
approved these changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 defaults in Avro in ennum type - one is on field level used for backwards compatibility, second is in "type" used for forwards compatibility, more in this article. I fixed forward-engineering of enum on both levels