Update generic-helpers.js #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when converting to word, it doesn't handle certain HTML entities well. It ends up displaying """ and so on.
Figured out by the time it reaches the wpml (which converts to WordProcessingML) function, the string was already escaped (although I don't know how it does that). So if you put quote (") in your resume JSON (e.g. a writing summary), it'll look like " at the START of the wpml function.
The problem is in line 386, it uses xml-escape to escape it again. So it'll end up as """, which in the end rendered on the document as """.
As such, I propose a change to ignore "&" when using xml-escape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when converting to word, it doesn't handle certain HTML entities well. It ends up displaying """ and so on.
Figured out by the time it reaches the wpml (which converts to WordProcessingML) function, the string was already escaped (although I don't know how it does that). So if you put quote (") in your resume JSON (e.g. a writing summary), it'll look like " at the START of the wpml function.
The problem is in line 386, it uses xml-escape to escape it again. So it'll end up as """, which in the end rendered on the document as """.
As such, I propose a change to ignore "&" when using xml-escape.