Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make instance compatible with ghc9 #370

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

brprice
Copy link
Contributor

@brprice brprice commented Apr 11, 2022

GHC 9 is more strict in what instances it accepts. In particular, the
instance must look (eliding some details) like
instance cxt => head
without any parentheses at top level. I.e.
instance (c => t)
would parse as "empty context, head = (c => t)", and be rightly
rejected.

GHC 9 is more strict in what instances it accepts. In particular, the
instance must look (eliding some details) like
  instance cxt => head
without any parentheses at top level. I.e.
  instance (c => t)
would parse as "empty context, head = (c => t)", and be rightly
rejected.
@brprice brprice requested a review from a team April 11, 2022 11:46
@dhess dhess added the Ready to merge Ready to merge label Apr 11, 2022
@mergify mergify bot merged commit 345063c into main Apr 11, 2022
@mergify mergify bot deleted the brprice/ghc9-compat-instance branch April 11, 2022 11:56
@georgefst
Copy link
Contributor

Ohh, OK, cool, that's less of a restriction than I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants