RFC/To-think-about: are these usages of Gen.justT potentially problematic? #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic? This commit should either - stay roughly the same, but with an explanatory commit message - or morph into adding some comments as to why these 'Gen.justT' are fine Note that these have been here since the beginning, and justT was introduced when genAPP was written 'genAPP = justT $ do ...'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this mostly so I don't forget about it. This may (or may not) be the root cause of test runs (rarely) oom-ing
This commit should either
Note that these have been here since the beginning, and justT was introduced when genAPP was written 'genAPP = justT $ do ...'