[dependencies] Provide "translation" service via "symfony/translation" instead of "sensio/framework-extra-bundle" #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phansys
commented
Dec 6, 2018
•
phansys
commented
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
- Provide "translation" service via "symfony/translation" instead of "sensio/framework-extra-bundle";
- Declare "SYMFONY_PHPUNIT_VERSION" at CI tests in order to avoid issues with nonexistent PHPUnit branches (see [Bridge/PhpUnit] Use composer to download phpunit symfony/symfony#29265, PHPUnit Version 5.7 Removed sebastianbergmann/phpunit#3413).
phansys
changed the title
…" instead of "sensio/framework-extra-bundle"
phansys
changed the title
phansys
added a commit
that referenced
this pull request
Dec 6, 2018
…/translation" instead of "sensio/framework-extra-bundle" (phansys) This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |--- | |Branch |master| |Bug fix? |yes | |New feature? |no | |BC breaks? |no | |Deprecations?|no | |Tests pass? |yes | |Fixed tickets|n/a | |License |MIT | |Doc PR |n/a | * Provide "translation" service via "symfony/translation" instead of "sensio/framework-extra-bundle"; * Declare "SYMFONY_PHPUNIT_VERSION" at CI tests in order to avoid issues with nonexistent PHPUnit branches (see symfony/symfony#29265, sebastianbergmann/phpunit#3413). Commits ------- dd8ec39 [dependencies] Provide "translation" service via "symfony/translation" instead of "sensio/framework-extra-bundle"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.