Fix bug with recursive bundles depending on items from original modules. #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As described here the problem is more complex than I usually thought if one wants to minimize the amount of bundled items. So this PR implements a conservative approach (that is much more simple than what we did before): when there is a cycle at the module level, it bundles together in a new module everything the content of all the modules in the cycle. #1005 will track whether this is practical enough and if we should find an algorithm to minimize bundles. |
|
Looks like tests snapshot are not up to date? 🤔 |
Yes, noticed that too. I am looking into it. |
maximebuyse
force-pushed
the
fix-cyclic-dependencies
branch
from
7b8f2ec
to
e0f0bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found while investigating #995 . More generally this fixes many problems in the bundling of cyclic dependencies