Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datafile issues #73

Closed
2 tasks done
werpuc opened this issue Oct 14, 2021 · 4 comments
Closed
2 tasks done

Fix datafile issues #73

werpuc opened this issue Oct 14, 2021 · 4 comments
Assignees

Comments

@werpuc
Copy link
Member

werpuc commented Oct 14, 2021

Our users reported issues when uploading their files. This should be investigated and fixed.

  • file from Kasia
  • file from Magda
@werpuc werpuc self-assigned this Oct 14, 2021
@werpuc
Copy link
Member Author

werpuc commented Oct 14, 2021

The issue with Kasia's file: there were no values for some peptides in the second state. Since we assigned the ID when calculating deuterium uptake, there was no match to calculate differential deuterium uptake, because of different ID values. To solve this, I deleted the ID from the deuterium uptake calculations and left it in datasets and differential calculations, where is it needed.

werpuc added a commit that referenced this issue Oct 14, 2021
werpuc added a commit that referenced this issue Oct 14, 2021
@werpuc
Copy link
Member Author

werpuc commented Oct 14, 2021

Magda's file has data for multiple proteins, and we did not test this scenario enough. Fixed.

werpuc added a commit that referenced this issue Oct 14, 2021
@werpuc werpuc closed this as completed Oct 14, 2021
@michbur
Copy link
Member

michbur commented Oct 20, 2021

These cases should be covered by tests.

@michbur michbur reopened this Oct 20, 2021
@werpuc werpuc mentioned this issue Nov 2, 2021
4 tasks
@werpuc
Copy link
Member Author

werpuc commented Nov 2, 2021

There is a new issue for UI tests ( #74 ). The scenarios from this task are included in the main task, so this one is closed.

@werpuc werpuc closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants