Fix native modules (#263)

* Update native modules for Windows * Remove unused dependency * FIx version check logic
hainproject · May 14, 2018 · c24d173 · c24d173
1 parent 65ee322
commit c24d173
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/app/main/plugins/hain-commands/index.js b/app/main/plugins/hain-commands/index.js
@@ -1,6 +1,7 @@
 'use strict';
 
 const lo_assign = require('lodash.assign');
+const semver = require('semver');
 
 const pkg = require('../../../package.json');
 const checkForUpdate = require('./check-update');
@@ -46,7 +47,10 @@ module.exports = (context) => {
 
   function startup() {
     checkForUpdate().then((ret) => {
-      if (ret.version !== pkg.version) {
+      const remoteVersion = ret.version;
+      const isValidVersion = semver.valid(remoteVersion);
+      const isNewVersion = semver.gt(remoteVersion, pkg.version);
+      if (isValidVersion && isNewVersion) {
         toast.enqueue(
           'New version available! Please enter `/hain update`.',
           2500

diff --git a/app/native/platform-util/win32-ia32.node b/app/native/platform-util/win32-ia32.node
diff --git a/app/native/platform-util/win32-x64.node b/app/native/platform-util/win32-x64.node
diff --git a/package.json b/package.json
@@ -28,7 +28,6 @@
     "del": "^2.2.0",
     "electron": "^2.0.0",
     "electron-packager": "^8.6.0",
-    "electron-rebuild": "^1.5.7",
     "electron-winstaller": "^2.5.2",
     "eslint": "^3.2.2",
     "eslint-config-prettier": "^2.9.0",