Skip to content
This repository has been archived by the owner on Jun 29, 2019. It is now read-only.

Preferences Input not working #184

Closed
appetizermonster opened this issue Sep 4, 2016 · 2 comments
Closed

Preferences Input not working #184

appetizermonster opened this issue Sep 4, 2016 · 2 comments
Labels
Milestone

Comments

@appetizermonster
Copy link
Collaborator

Version: Hain 0.5.0

@appetizermonster appetizermonster added this to the Backlog milestone Sep 4, 2016
@gsgeschke
Copy link
Contributor

@appetizermonster I think the problem occurs here:

https://github.com/appetizermonster/hain/blob/master/app/renderer-jsx/schema-form/schema-form.jsx#L41

The path has a leading dot and that causes lo_set to create a new object in the model for the preference change.

For example, after loading preferences, and clicking the 'Clear query after window is closed" checkbox, the preferences that gets written looks like this:

{"":{"clearQuery":true},"clearQuery":false,"customQueryShortcuts":[],"proxy":{"host":"","port":80,"useProxy":null},"shortcut":"alt+space"}

Notice that there are now two clearQuery elements, the first one on the empty "" object.

appetizermonster added a commit that referenced this issue Sep 13, 2016
@appetizermonster
Copy link
Collaborator Author

Resolved at 55345eb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants