Don't remove cache when token is invalid #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Aug 19, 2023
src/remote-wipe-service.cpp
Outdated
| @@ -77,7 +77,7 @@ void RemoteWipeService::onRequestFailed(const ApiError& error) | |||
| // but we only handle this error here to avoid complicate code since it is | |||
| // general enough. | |||
| if (error.type() == ApiError::HTTP_ERROR && error.httpErrorCode() == 401) { | |||
| askDaemonDeleteAccount(req->account()); | |||
| askDaemonDeleteAccount(req->account(), false); | |||
| gui->warningBox(tr("Authorization expired, please re-login")); | |||
| gui->accountManager()->disableAccount(req->account()); | |||
There was a problem hiding this comment.
这里应该可以直接调用 account_mgr 的 removeAccount 函数吧？就不用走 askDaemonDeleteAccount。否则 GUI 这里的账号还在，但是底层的账号已经没了，不一致。而且界面上留着这个账号也没用。
feiniks
force-pushed
the
fix_remove_cache
branch
from
88c70bf
to
ada3f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.