Fix app not moving in wayland by using the startSystemMove() method #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpemwarrior
changed the title
|
Any feedback on this? |
|
This does fix the problem for me in the latest KDE/Wayland under Arch. It would be nice if it was merged. |
|
Any update on this? |
alpemwarrior
force-pushed
the
fix_wayland
branch
from
bc58f8b
to
70a4e26
Compare
|
I've rebased this on top of the current master (not that there were any conflicts). |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #991, where the app could not be moved under wayland because the protocol does not allow windows to move themselves. This method was introduced in qt 5.15 and is currently recommended when using client-side decorations as it allows for native look and feel.
I have only tested this under under wayland and xwayland but it should be a drop-in replacement in Windows, Linux and Macos. Testing would be appreciated nonetheless.