New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync error SYNC_ERROR_ID_CHECKOUT_FILE #1479

Merged

killing merged 2 commits into master from checkout_file

Jul 20, 2023

Contributor

feiniks commented Jul 20, 2023

No description provided.


          Add sync error SYNC_ERROR_ID_CHECKOUT_FILE

f604282

killing reviewed

View reviewed changes

src/message-poller.cpp Outdated

                       case SYNC_ERROR_ID_TOO_MANY_FILES:
                           msg = tr("Too many files in library");
                           break;
+                      case SYNC_ERROR_ID_CHECKOUT_FILE:
+                          msg = tr("Failed to checkout file on the client. Please check disk space or folder permissions");

Member

killing Jul 20, 2023

checkout 这种词属于内部的技术术语，不应该暴露给用户。改为 Failed to download file %1. Please check disk space or folder permissions.

另外，这个错误也应该在界面上持久保存吧，不会被后续的同步覆盖掉。


          Persist checkout file error

2c8697d

killing merged commit 841daff into master

killing deleted the checkout_file branch

July 20, 2023 10:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet