Add username to daemon #1544
Merged
Add username to daemon #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Jun 27, 2024
src/ui/create-repo-dialog.cpp
Outdated
| @@ -208,6 +208,8 @@ bool CreateRepoDialog::validateInputs() | |||
| void CreateRepoDialog::createSuccess(const RepoDownloadInfo& info) | |||
| { | |||
| QString error; | |||
| QString username = account_.accountInfo.name; | |||
| QString more_info = rebuildMoreInfo(info.more_info, "username", toCStr(username)); | |||
There was a problem hiding this comment.
可以在 DownloadRepoRequest 里面统一把 username 信息填入，这样就不用在多个地方 rebuildMoreInfo 了。
killing
reviewed
Jun 28, 2024
src/utils/utils.h
Outdated
| @@ -99,4 +99,6 @@ const QRect getScreenSize(int index); | |||
|
|
|||
| QString trimNULL(QString& s); | |||
|
|
|||
| QString rebuildMoreInfo (const QString& more_info, const char *key, const char *value); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.