Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing: hash64 missing x64arch argument #51

Closed
tcmitchell opened this issue Oct 23, 2023 · 1 comment
Closed

Typing: hash64 missing x64arch argument #51

tcmitchell opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels

Comments

@tcmitchell
Copy link

The code for mmh3_hash64 in mmh3module.c has a x64arch argument, but the typing file __init__.pyi does not declare this as an argument to hash64. The result is a mypy error if code uses the x64arch keyword argument.

@hajimes hajimes self-assigned this Jan 2, 2024
@hajimes hajimes added the bug label Jan 2, 2024
@hajimes
Copy link
Owner

hajimes commented Jan 9, 2024

Thank you so much for reporting the problem. A fix to this issue was released in 4.1.0. Incidentally, I was able to find another bug on s390x (#52) when testing the fix to this issue, so your report is doubly appreciated.

@hajimes hajimes closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants