-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with updated built-in LoRA extension #170
Comments
Thanks for the info. |
I believe it has probably been fixed. However, there still seem to be issues with the built-in Lora code. |
Working for me as of AUTOMATIC1111/stable-diffusion-webui@2f98f7c as well, thanks!
Is this in reference to the PR or this extension? Not sure what "old Lora option" you're referring to. |
Lora/Networks: use old method that takes longer when you have multiple Loras active and produces same results as kohya-ss/sd-webui-additional-networks extension |
Ah, I see it now. Is that required though, or are you just making sure it's supported? Asking since if it is required that isn't listed in the README anywhere. I'm also not as familiar with how to use latent mode with multiple LoRAs so likely somebody else would need to chime in if they could help. |
It is not necessary, but it is better to use it. |
1.5 is already in the release candidate phase so it may be worth reporting now. There's a Discord channel too where you may be able to discuss the matter with Auto. https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Contributing |
Semi-related to #141. See AUTOMATIC1111/stable-diffusion-webui#11821 for the full details.
Currently, this extension references the
multiplier
attribute a lot. As of the latest dev version for the upcoming 1.5.0 release of the web UI, this has been replaced by a separatete_multiplier
andunet_multiplier
, as seen here: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/a99d5708e6d603e8f7cfd1b8c6595f8026219ba0/extensions-builtin/Lora/network.py#L87-L95From having a cursory look at the PR it also looks like there's now built-in functions like
calc_scale
, something that I believe is being done manually in the current extension code.sd-webui-regional-prompter/scripts/latent.py
Lines 392 to 395 in 0624834
The text was updated successfully, but these errors were encountered: