Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCL intrinsics for float16 seem to have neg_inf and inf switched #8257

Closed
shoaibkamil opened this issue Jun 3, 2024 · 0 comments · Fixed by #8266
Closed

OpenCL intrinsics for float16 seem to have neg_inf and inf switched #8257

shoaibkamil opened this issue Jun 3, 2024 · 0 comments · Fixed by #8266
Labels
bug

Comments

@shoaibkamil
Copy link
Contributor

It looks to me like these lines are incorrect:

Halide/src/CodeGen_OpenCL_Dev.cpp

Line 1189 in 7ca95d8

<< "inline half neg_inf_f16() { return half_from_bits(31744); }\n"

I believe negative infinity should be 64512 and positive infinity should be 31744.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OpenCL positive and negative INF constants. halide/Halide
1 participant
@shoaibkamil