Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default device wrap native function #6310

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fix default device wrap native function #6310

merged 2 commits into from
Oct 25, 2021

Commits on Oct 12, 2021

  1. Fix default device wrap native function 

    Currently, an attempt to call device_wrap_native on a target that uses
the default device wrap native function will result in an error of type
halide_error_device_interface_no_device, namely in the OpenGLCompute and
the Hexagon targets. This happens because the default wrap native
function calls debug_log_and_validate_buf after the device_interface is
set in halide_device_wrap_native but before the device handle is set,
which is validated as a bad state.

This patch removes the validation call and adds an assert for the handle
much like the other wrap_native implementations in other targets.
    @OmarEmaraDev
    OmarEmaraDev committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    bf3d76a View commit details
    Browse the repository at this point in the history

  2. Use approperiate error code

    @OmarEmaraDev
    OmarEmaraDev committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    afd7059 View commit details
    Browse the repository at this point in the history