Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mullapudi2016: don't hardcode the list of supported targets #6520

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Mullapudi2016: don't hardcode the list of supported targets #6520

merged 1 commit into from
Dec 29, 2021

Conversation

LebedevRI
Copy link
Contributor

@LebedevRI LebedevRI commented Dec 28, 2021 •
edited by alexreinking
Loading

As discussed in #6518,
this is a bit dubious, and e.g. prevents building on RISC-V,
because there is no way to not build autoschedulers currently.

Closes #6518

@LebedevRI
Mullapudi2016: don't hardcode the list of supported targets
77d112f 
As discussed in halide#6518,
this is a bit dubious, and e.g. prevents building on RISC-V,
because there is no way to not build autoschedulers currently.
@LebedevRI LebedevRI mentioned this pull request Dec 28, 2021
Closed
alexreinking
alexreinking approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexreinking alexreinking added autoscheduler Related to one or more of the Autoschedulers backport me This change should be backported to release versions labels Dec 28, 2021
@alexreinking
Copy link
Member

Failures are unrelated -- same upstream failure (arm64/llvm14)

@alexreinking alexreinking merged commit 6ed65ba into halide:master Dec 29, 2021
@LebedevRI LebedevRI deleted the Mullapudi2016-drop-assert branch December 29, 2021 22:58
@LebedevRI
Copy link
Contributor Author

@alexreinking thank you!

alexreinking pushed a commit that referenced this pull request Jan 5, 2022
@LebedevRI @alexreinking
Mullapudi2016: don't hardcode the list of supported targets (#6520)
7568454 
As discussed in #6518,
this is a bit dubious, and e.g. prevents building on RISC-V,
because there is no way to not build autoschedulers currently.

(cherry picked from commit 6ed65ba)
@alexreinking alexreinking mentioned this pull request Jan 5, 2022
Merged
@alexreinking alexreinking removed the backport me This change should be backported to release versions label Jan 5, 2022
alexreinking pushed a commit that referenced this pull request Jan 6, 2022
@LebedevRI @alexreinking
Mullapudi2016: don't hardcode the list of supported targets (#6520)
0818b8c 
As discussed in #6518,
this is a bit dubious, and e.g. prevents building on RISC-V,
because there is no way to not build autoschedulers currently.

(cherry picked from commit 6ed65ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvookin zvookin zvookin approved these changes

@alexreinking alexreinking alexreinking approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees
No one assigned
Labels
autoscheduler Related to one or more of the Autoschedulers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LebedevRI @alexreinking @zvookin