Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for top-of-tree LLVM (#6546) #6548

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fixes for top-of-tree LLVM (#6546) #6548

merged 1 commit into from
Jan 10, 2022

Conversation

steven-johnson
Copy link
Contributor

No description provided.

@steven-johnson
Copy link
Contributor Author

Attn @LebedevRI

@LebedevRI
Copy link
Contributor

Attn @LebedevRI

Thank you for looking into it!

Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo language version

@@ -1088,6 +1104,10 @@ $(BIN_DIR)/binary2cpp: $(ROOT_DIR)/tools/binary2cpp.cpp
@mkdir -p $(@D)
$(CXX) $< -o $@

$(BIN_DIR)/regexp_replace: $(ROOT_DIR)/tools/regexp_replace.cpp
@mkdir -p $(@D)
$(CXX) -std=c++11 $< -o $@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++17, surely

@steven-johnson
Copy link
Contributor Author

HVX still broken, needs further investigation

@steven-johnson steven-johnson merged commit 34cfde3 into master Jan 10, 2022
@steven-johnson steven-johnson deleted the srj/llvm-hvx-fix branch January 10, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants