Move GeneratorContext into a standalone class #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
added
the
release_notes
alexreinking
approved these changes
Feb 16, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some under-the-hood work to make experiments in implementing Generate in Python a bit more tractable. Currently, GeneratorContext is a base class for Generator, but can't really be used in standalone form (e.g. it's not copyable). For various reasons, this makes the Python code a lot more unpleasant to deal with, so this PR now moves the equivalent of a GeneratorContext inside Generator -- dispensing with the inheritance -- and makes GeneratorComplex much simpler for Python to deal with.
The change should be 100% to downstream code
, EXCEPT for code that uses GeneratorStubs -- the first argument to the stub must now beEDIT: I added an overload to allow existing code to work as-is.context()rather thanthis. AFAIK literally no one outside Google has ever used these, so I'd rather just make the small breaking change here and fix the affected areas.Drive-by change of moving the ValueTracker into Generator.cpp.