Disallow Type::narrow() and Type::widen() from producing bitwidths between 1 and 8 bits
#6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween 1 and 8 bits
|
What should happen if you narrow a uint1? |
|
@abadams I guess either an error, or a |
|
An error sgtm |
rootjalex
requested review from
halidebuildbots and
abadams
and removed request for
halidebuildbots
|
Test failure seems unrelated |
abadams
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing these methods to create bitwidths of
2and4can cause issues withfind_intrinsics. Specifically, this fixes #6601 .Discussed with @abadams .