Wild match object should not be foldable #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootjalex
changed the title
rootjalex
requested review from
halidebuildbots
and removed request for
halidebuildbots
abadams
approved these changes
Feb 24, 2022
|
Looks like there are some failures |
|
This PR just deletes some dead code, so I think those failures are a fresh llvm injection. |
|
Good to merge then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildobjects should not be foldable,WildConstshould be used when matching against constants. There are no use cases of aWildobject being folded, so this should be removed unless there is a relevant use-case.