Eliminate some unnecessary clamping in ClampUnsafeAccesses (#6297) #6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks right to me but I would like @alexreinking to chime in too, if he has time. |
|
This seems fine given our current (plans for the) bounds inference implementation, but the property this optimization exploits isn't inherent to the concept. We could one day analyze overcompute more precisely in these cases and then this code would silently break. |
alexreinking
approved these changes
Mar 19, 2022
...I'm reluctant to check in code that could silently break. Let me see if I can come up with a test that would catch breakage... |
|
Landing per offline discussion with @alexreinking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at @abadams suggestion for a simple improvement.