Couple small fixes to update RISC V to current LLVM flags and enable vscale use. #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +51,7 @@ string CodeGen_RISCV::mattrs() const { | |||
| string arch_flags = "+m,+a,+f,+d,+c"; | |||
|
|
|||
| if (target.has_feature(Target::RVV)) { | |||
| arch_flags += ",+experimental-v"; | |||
| arch_flags += ",+v"; | |||
There was a problem hiding this comment.
Does this need to be conditional on LLVM_VERSION?
There was a problem hiding this comment.
Interesting question. I'm tempted to say we don't want to support something that was experimental. Like if one is using RISC V vector, one wants to be at least this recent on LLVM. (And it will not be a build time issue.) Note it's been broken for maybe a few months so anyone actually using it was making this change by hand. Think it is a safe bet to not conditionalize.
steven-johnson
approved these changes
Sep 5, 2022
|
LGTM |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…vscale use. (halide#6995) Couple small fixes to update RISC V to current LLVM flags and enable vscale use. Co-authored-by: Steven Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector extension is no longer experimental and the logic for picking the vector size and vscale was not hooked up.