Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Adams2019 CMake file #7003

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Clean up Adams2019 CMake file #7003

merged 1 commit into from
Sep 9, 2022

Conversation

steven-johnson
Copy link
Contributor

This does a few things:

  • The main thing it does is add a unique prefix to all the targets in Adams2019; apparently CMake has a global namespace for targets, and when they collide (as happened in Add GPU autoscheduler #6856) you get amusing results.
  • Added add_adams2019_test helper to clean up boilerplate. Note that setting HL_TARGET was never necessary for any of these tests.

alexreinking
alexreinking approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to reorganize the autoscheduler tests under... tests/...

@steven-johnson
Copy link
Contributor Author

We really need to reorganize the autoscheduler tests under... tests/...

And rename them to Mullapudi1

@steven-johnson steven-johnson merged commit 4e352d3 into main Sep 9, 2022
@steven-johnson steven-johnson deleted the srj/adams2019-cmake branch September 9, 2022 16:49
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@steven-johnson @ardier
Clean up Adams2019 CMake file (halide#7003)
28e6611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexreinking alexreinking alexreinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steven-johnson @alexreinking