Codegen_C for user_context #7031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vksnk
approved these changes
Sep 20, 2022
| @@ -2069,7 +2069,12 @@ void CodeGen_C::visit(const Variable *op) { | |||
| // This is the name of a global, so we can't modify it. | |||
| id = op->name; | |||
| } else { | |||
| id = print_name(op->name); | |||
| // This substitution ensures const correctness for all calls | |||
| if (op->name == "__user_context") { | |||
There was a problem hiding this comment.
Worth adding a helper function to check if the name is "__user_context?
|
Failures are unrelated, merging |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
Codegen_C fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding a user_context to the
async_parallelgenerator for other purposes, I found some subtle bugs in Codegen_C regarding possible aliasing and/or const-correctness of the internal 'ucon' arguments when calling or unpacking a closure for async usage. This fixes it.