Update onnx app to Adams2019 autoscheduler and new autoscheduler API #7673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If python3-onnx is installable via pip that would be easy to correct on the bots |
|
Is https://pypi.org/project/onnx/ what we need? |
|
(If we can install the right packages, let's do that first and get testing working before we land this) |
|
We can do that, but note that doing it in that order will result in all other PRs failing their makefile builds until this PR goes in. |
|
Ah, ok, approving then |
steven-johnson
approved these changes
Jul 10, 2023
|
Errors unrelated (they are also occuring on main) |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…alide#7673) * Update onnx app to Adams2019 autoscheduler and new autoscheduler API Fixes halide#7670 * Add model test too * Remove use of tmpnam * Don't test onnx app in a 32-bit build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7670
This app had rotted, largely because the linux bots don't have the prereqs installed so they weren't testing it. Unfortunately one of the prereqs seems to be the package python3-onnx, which isn't available on the ubuntu distribution installed on the bots (focal fossa).