Don't return an undefined Stmt() from IfThenElse visitor #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Aug 28, 2023
|
clang-tidy failure will be fixed by #7817, should be good to land if final bot passes cleanly |
|
Note that the mac failures are unique to macbot3 -- it was recently set up by @alexreinking but is failing (consistently) in odd ways we haven't seen before |
|
Also note that the hvx failures seem to be in all PRs -- no idea when/where they were injected, but it was within the past few days, anyone want to take a look? @pranavb-ca any ideas? |
|
Failures unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7815